mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Michael Park <mp...@apache.org>
Subject Re: Review Request 43411: Windows: Added dynamic library loading tests to build.
Date Thu, 25 Feb 2016 00:09:36 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43411/#review120616
-----------------------------------------------------------


Fix it, then Ship it!





3rdparty/libprocess/3rdparty/stout/tests/dynamiclibrary_tests.cpp (line 54)
<https://reviews.apache.org/r/43411/#comment182083>

    Let's we pull this string out as `invalid_symbol` and just use `"InvalidSymbol"`



3rdparty/libprocess/3rdparty/stout/tests/dynamiclibrary_tests.cpp (lines 69 - 70)
<https://reviews.apache.org/r/43411/#comment182084>

    We're only testing that `loadSymbol` fails if we don't call `open` first, not `close`.
Right? Seems like this was copy/pasted from above test.



3rdparty/libprocess/3rdparty/stout/tests/dynamiclibrary_tests.cpp (line 92)
<https://reviews.apache.org/r/43411/#comment182085>

    Let's also take this out to `invalid_library_path` and call it `"InvalidLibraryPath"`


- Michael Park


On Feb. 18, 2016, 12:59 a.m., Alex Clemmer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43411/
> -----------------------------------------------------------
> 
> (Updated Feb. 18, 2016, 12:59 a.m.)
> 
> 
> Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, Joris Van Remoortere,
Michael Park, M Lawindi, and Yi Sun.
> 
> 
> Bugs: MESOS-4496
>     https://issues.apache.org/jira/browse/MESOS-4496
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Windows: Added dynamic library loading tests to build.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/3rdparty/stout/tests/CMakeLists.txt 3c65d0422dc6e198180d53d1c9e6cb2839137434

>   3rdparty/libprocess/3rdparty/stout/tests/dynamiclibrary_tests.cpp 27626ae28db090f1a002239ff5c674b82e8fc9a8

> 
> Diff: https://reviews.apache.org/r/43411/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message