mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Michael Park <mp...@apache.org>
Subject Re: Review Request 43461: Used C++11 for loop to iterate std list/set.
Date Wed, 24 Feb 2016 19:45:25 GMT


> On Feb. 24, 2016, 7:30 p.m., Vinod Kone wrote:
> > LGTM. Though I'm not sure why we used iterators instead of foreach in the first
place. cc @mcypark

Because it was written before `foreach` was introduced to stout. The last of the `for` loops
here was authored 2011-10-31 and `foreach` was introduced 2012-07-11.


- Michael


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43461/#review120552
-----------------------------------------------------------


On Feb. 24, 2016, 7:19 p.m., Cong Wang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43461/
> -----------------------------------------------------------
> 
> (Updated Feb. 24, 2016, 7:19 p.m.)
> 
> 
> Review request for mesos, Ben Mahler, Ian Downes, and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Used C++11 for loop to iterate std list/set.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/include/process/future.hpp 77655f22ad4ce6e81fd46bcdebbf2a82786e8f49

> 
> Diff: https://reviews.apache.org/r/43461/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Cong Wang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message