mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joseph Wu <jos...@mesosphere.io>
Subject Re: Review Request 43850: Added waits at different points in the test to ensure milestones.
Date Wed, 24 Feb 2016 17:38:13 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43850/#review120526
-----------------------------------------------------------




src/tests/containerizer/memory_pressure_tests.cpp (lines 158 - 161)
<https://reviews.apache.org/r/43850/#comment181986>

    Presumably, this section has the same race.



src/tests/containerizer/memory_pressure_tests.cpp (line 253)
<https://reviews.apache.org/r/43850/#comment181987>

    Missed s/status/running/ here.


- Joseph Wu


On Feb. 24, 2016, 1:10 a.m., Alexander Rojas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43850/
> -----------------------------------------------------------
> 
> (Updated Feb. 24, 2016, 1:10 a.m.)
> 
> 
> Review request for mesos, Bernd Mathiske and Joseph Wu.
> 
> 
> Bugs: MESOS-4047
>     https://issues.apache.org/jira/browse/MESOS-4047
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Sometimes MemoryPressureMesosTest.CGROUPS_ROOT_SlaveRecovery will fail because
> the tracker of the cgroups pressure counter is not finished by the time the
> expectations are set.
> 
> This patch ensures that different test milestones are reached; e.g. slave
> is registered, KILLED_TASK reached the scheduler, etc; before continuing
> with the test.
> 
> 
> Diffs
> -----
> 
>   src/tests/containerizer/memory_pressure_tests.cpp 4a03af2c9c0643d964b1d76e2096341b59bf5dce

> 
> Diff: https://reviews.apache.org/r/43850/diff/
> 
> 
> Testing
> -------
> 
> On a CentOS 6.7 virtual box machine:
> 
> ```bash
> MESOS_VERBOSE=1 sudo .libs/mesos-tests --gtest_filter="MemoryPressureMesosTest.CGROUPS_ROOT_SlaveRecovery"
--gtest_repeat=1000 --gtest_break_on_failure
> ```
> 
> 
> Thanks,
> 
> Alexander Rojas
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message