mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Guangya Liu <gyliu...@gmail.com>
Subject Re: Review Request 43881: Added allocator metric for the number of allocations to a framework.
Date Wed, 24 Feb 2016 00:53:40 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43881/#review120422
-----------------------------------------------------------




src/master/allocator/mesos/hierarchical.cpp (line 1197)
<https://reviews.apache.org/r/43881/#comment181863>

    The allocator do not know what is offer, does it make sense to rename this metrics to
`allocator/framework_allocations`



src/master/allocator/mesos/hierarchical.cpp (line 1354)
<https://reviews.apache.org/r/43881/#comment181856>

    The counter may count twice for some cases, one framework may get resource allocation
in both allocation stage1(Quota) and stage2(wDRF).



src/tests/hierarchical_allocator_tests.cpp (lines 2359 - 2360)
<https://reviews.apache.org/r/43881/#comment181861>

    4 spaces



src/tests/hierarchical_allocator_tests.cpp (lines 2369 - 2370)
<https://reviews.apache.org/r/43881/#comment181857>

    What about following format?
    
    allocator->setQuota(
        framework1.role(),
        createQuota(framework1.role(),
        "disk:10"));



src/tests/hierarchical_allocator_tests.cpp (line 2371)
<https://reviews.apache.org/r/43881/#comment181862>

    s/Setting/Setting a



src/tests/hierarchical_allocator_tests.cpp (lines 2390 - 2395)
<https://reviews.apache.org/r/43881/#comment181859>

    4 spaces



src/tests/hierarchical_allocator_tests.cpp (lines 2400 - 2403)
<https://reviews.apache.org/r/43881/#comment181858>

    4 spaces



src/tests/hierarchical_allocator_tests.cpp (lines 2416 - 2418)
<https://reviews.apache.org/r/43881/#comment181860>

    4 spaces


- Guangya Liu


On 二月 23, 2016, 5:09 p.m., Benjamin Bannier wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43881/
> -----------------------------------------------------------
> 
> (Updated 二月 23, 2016, 5:09 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov and Ben Mahler.
> 
> 
> Bugs: MESOS-4719
>     https://issues.apache.org/jira/browse/MESOS-4719
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added allocator metric for the number of allocations to a framework.
> 
> 
> Diffs
> -----
> 
>   src/master/allocator/mesos/hierarchical.hpp 0d39d3f3b5f4ff7f62f9de7200d062845c71818a

>   src/master/allocator/mesos/hierarchical.cpp 5ef29f26ec8071f79c2f4f78dbe2bb0a613cc92d

>   src/tests/hierarchical_allocator_tests.cpp 1af5c9870430eb05ca0b19ece0ca2957a05093ff

> 
> Diff: https://reviews.apache.org/r/43881/diff/
> 
> 
> Testing
> -------
> 
> make check (OS X)
> 
> I confirmed that this does not lead to general performance regressions in the allocator;
this is partially expected since the added code only inserts metrics in the allocator while
the actual work is perform asynchronously. These tests where performed with `HierarchicalAllocator_BENCHMARK_Test.DeclineOffers`
on an optimized build under OS X using clang(trunk) as compiler.
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message