mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jie Yu <yujie....@gmail.com>
Subject Re: Review Request 43854: Fixed chdir to an empty directory error.
Date Wed, 24 Feb 2016 00:23:44 GMT


> On Feb. 23, 2016, 6:40 a.m., Timothy Chen wrote:
> > src/slave/containerizer/mesos/isolators/docker/runtime.cpp, line 354
> > <https://reviews.apache.org/r/43854/diff/1/?file=1264856#file1264856line354>
> >
> >     Do we have tests to test the docker runtime isolator?

Yeah, I think he's adding one. Need a few test abstractions to do that.


- Jie


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43854/#review120268
-----------------------------------------------------------


On Feb. 22, 2016, 10:52 p.m., Gilbert Song wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43854/
> -----------------------------------------------------------
> 
> (Updated Feb. 22, 2016, 10:52 p.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Jie Yu, and Timothy Chen.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Fixed chdir to an empty directory error.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/mesos/isolators/docker/runtime.cpp 1bb5e28c4aefe70f9ebfb76b0a65973aaf7273f6

> 
> Diff: https://reviews.apache.org/r/43854/diff/
> 
> 
> Testing
> -------
> 
> make check (ubuntu14.04 + clang-3.6)
> 
> Tested with /mesos-execute --docker_image=busybox
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message