mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Neil Conway <neil.con...@gmail.com>
Subject Re: Review Request 43864: Fix typo of roles doc.
Date Tue, 23 Feb 2016 18:06:20 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43864/#review120347
-----------------------------------------------------------



The right place to make this fix is in `src/master/http.cpp`, and then rerun `support/generate-endpoint-help.py`.
Seems like `Master::Http::ROLES_HELP` is missing commas in `DESCRIPTION`.

- Neil Conway


On Feb. 23, 2016, 3:20 a.m., Klaus Ma wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43864/
> -----------------------------------------------------------
> 
> (Updated Feb. 23, 2016, 3:20 a.m.)
> 
> 
> Review request for mesos and Neil Conway.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Fix typo of roles doc.
> 
> 
> Diffs
> -----
> 
>   docs/endpoints/master/roles.json.md d67779c246cceae2209f2611f32ada4493ae6f83 
>   docs/endpoints/master/roles.md 976a9b7891a17652289126ec7e7ee73cea0c2e35 
> 
> Diff: https://reviews.apache.org/r/43864/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Klaus Ma
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message