mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Guangya Liu <gyliu...@gmail.com>
Subject Re: Review Request 43860: Used uri::Fetcher to pull docker images in docker registry puller.
Date Tue, 23 Feb 2016 07:45:46 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43860/#review120273
-----------------------------------------------------------



Some doc may also need to be changed by removing the ssl related configurations, such as 

https://github.com/apache/mesos/blob/master/docs/endpoints/slave/state.json.md
https://github.com/apache/mesos/blob/master/docs/endpoints/slave/state.md
https://github.com/apache/mesos/blob/master/docs/configuration.md


src/slave/containerizer/mesos/provisioner/docker/registry_puller.cpp (line 158)
<https://reviews.apache.org/r/43860/#comment181708>

    what about highlighting the words with `` but not ''?



src/slave/containerizer/mesos/provisioner/docker/registry_puller.cpp (lines 236 - 237)
<https://reviews.apache.org/r/43860/#comment181709>

    What about keep this log but update it to "Fetching layer "



src/tests/containerizer/provisioner_docker_tests.cpp (line 325)
<https://reviews.apache.org/r/43860/#comment181707>

    most of the test with docker images are now using `alpine`


- Guangya Liu


On 二月 23, 2016, 12:54 a.m., Jie Yu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43860/
> -----------------------------------------------------------
> 
> (Updated 二月 23, 2016, 12:54 a.m.)
> 
> 
> Review request for mesos, Gilbert Song, Jojy Varghese, and Timothy Chen.
> 
> 
> Bugs: MESOS-4261 and MESOS-4499
>     https://issues.apache.org/jira/browse/MESOS-4261
>     https://issues.apache.org/jira/browse/MESOS-4499
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This is the second step of cleaning/simplying the docker registry puller code.
> 
> The new code uses the uri::Fetcher to download docker manifest and blobs (instead of
writting our own http logic which requires enabling of SSL for Mesos).
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/mesos/provisioner/docker/puller.hpp 5b2d72c22fcbcc379b4901607cf3eb682de66206

>   src/slave/containerizer/mesos/provisioner/docker/puller.cpp a239b97557ad20353c67050dbc89ef16da898330

>   src/slave/containerizer/mesos/provisioner/docker/registry_puller.hpp bccbac11113357cf942446604e6cf5d16c3d594b

>   src/slave/containerizer/mesos/provisioner/docker/registry_puller.cpp 3fcf1471a035e35a2cac22442655ad65a84a9793

>   src/slave/containerizer/mesos/provisioner/docker/store.cpp 2f1d3e002140f34c646aab445a419c9c3d712f99

>   src/slave/flags.hpp 54c1a69d8777f417cdd8f73ce638447d9951ab61 
>   src/slave/flags.cpp 855812e9f7cb4b96d4297f4bd5ac5de7f1d3c39a 
>   src/slave/http.cpp a18085ea020d0d6c39f23213e11af75a02eedb7e 
>   src/tests/containerizer/provisioner_docker_tests.cpp 4db6793a21abbb7ea4de0d0fca0431237d38d013

> 
> Diff: https://reviews.apache.org/r/43860/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Jie Yu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message