mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Qian Zhang <zhang...@cn.ibm.com>
Subject Re: Review Request 43489: KillTask introduces TASK_KILLING state.
Date Mon, 22 Feb 2016 01:21:19 GMT


> On Feb. 21, 2016, 12:30 a.m., Ben Mahler wrote:
> > src/launcher/executor.cpp, lines 460-469
> > <https://reviews.apache.org/r/43489/diff/3/?file=1241846#file1241846line460>
> >
> >     Let's do this inside shutdown per my comment at the top.
> >     
> >     It's also not clear to me why the health check process is only killed inside
killTask, seems that we'll leak the health check process if we only are sent shutdown! Looks
like a bug :(

Is it because the health check process is part of the executor process group and once executor
is shutdown it will be terminated too?


- Qian


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43489/#review120043
-----------------------------------------------------------


On Feb. 16, 2016, 6:23 p.m., Abhishek Dasgupta wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43489/
> -----------------------------------------------------------
> 
> (Updated Feb. 16, 2016, 6:23 p.m.)
> 
> 
> Review request for mesos, Ben Mahler and Qian Zhang.
> 
> 
> Bugs: MESOS-4547
>     https://issues.apache.org/jira/browse/MESOS-4547
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> KillTask introduces TASK_KILLING state.
> 
> 
> Diffs
> -----
> 
>   src/docker/executor.cpp 654a41db843a85d953880d5145bc95ada9ed2920 
>   src/launcher/executor.cpp c27e0792e4b9bcec0829a46be4232c013d965cf9 
> 
> Diff: https://reviews.apache.org/r/43489/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Abhishek Dasgupta
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message