mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Qian Zhang <zhang...@cn.ibm.com>
Subject Re: Review Request 43489: KillTask introduces TASK_KILLING state.
Date Fri, 19 Feb 2016 08:32:19 GMT


> On Feb. 18, 2016, 9:44 a.m., Qian Zhang wrote:
> > I see you send TASK_KILLING once the killTask() is invoked. However, according to
the description of MESOS-4140, we may need to send such status update after SIGTERM is sent
to the task and before SIGKILL is sent. So maybe you should send TASK_KILLING in shutdown()
instead?
> 
> Abhishek Dasgupta wrote:
>     Okay, i see. but in the case of docker executor, TASK_KILLING should come after docker
stop. Does it sound good??
> 
> Abhishek Dasgupta wrote:
>     Actually, to set the status, we need to send the task_id also. Task_id is not available
inside shutdown. Moreover, I don't think it will make any difference if it is called inside
shutdown instead of killTask. It makes sense to change the status a TASK_KILLING as soon as
killTask is issued.

shutdown() will be not only called by killTask(), but also called when the executor itself
is asked to shutdown, so if you send the status in killTask(), that means for the latter case
(executor shutdown), the TASK_KILLING status will not be sent?


- Qian


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43489/#review119568
-----------------------------------------------------------


On Feb. 16, 2016, 6:23 p.m., Abhishek Dasgupta wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43489/
> -----------------------------------------------------------
> 
> (Updated Feb. 16, 2016, 6:23 p.m.)
> 
> 
> Review request for mesos, Ben Mahler and Qian Zhang.
> 
> 
> Bugs: MESOS-4547
>     https://issues.apache.org/jira/browse/MESOS-4547
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> KillTask introduces TASK_KILLING state.
> 
> 
> Diffs
> -----
> 
>   src/docker/executor.cpp 654a41db843a85d953880d5145bc95ada9ed2920 
>   src/launcher/executor.cpp c27e0792e4b9bcec0829a46be4232c013d965cf9 
> 
> Diff: https://reviews.apache.org/r/43489/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Abhishek Dasgupta
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message