mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jie Yu <yujie....@gmail.com>
Subject Re: Review Request 42516: Add support for user-defined networks.
Date Thu, 18 Feb 2016 22:44:37 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42516/#review119730
-----------------------------------------------------------




include/mesos/v1/mesos.proto (lines 1543 - 1544)
<https://reviews.apache.org/r/42516/#comment181075>

    We're going to introduce a ContainerInfo.NetworkInfo.name to allow frameworks to specify
the network they want to join. Note that  NetworkInfo in ContainerInfo is repeated which allows
us to express the situation where a container wants to join multiple networks.
    
    As we did for ContainerInfo.volumes, I think command configurations for a container should
go to top level. This also avoids the confusion that 'network_name' is set in DockerInfo while
there's another NetworkInfo.name.
    
    I think what I am proposing is that: we add a NetworkInfo.name, and if DOckerInfo.network
is not set and NetworkInfo.name is set, the docker containerizer will do --net=<NetworkInfo.name>.


- Jie Yu


On Feb. 16, 2016, 12:39 p.m., Ezra Silvera wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42516/
> -----------------------------------------------------------
> 
> (Updated Feb. 16, 2016, 12:39 p.m.)
> 
> 
> Review request for mesos and Timothy Chen.
> 
> 
> Bugs: MESOS-4369
>     https://issues.apache.org/jira/browse/MESOS-4369
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Signed-off-by: Ezra Silvera <ezra@il.ibm.com>
> 
> 
> Diffs
> -----
> 
>   include/mesos/mesos.proto 0bd5abadb5abe052161963ca995c396f1ed832f2 
>   include/mesos/v1/mesos.proto 38e04cb19e303d1c71d2afad6ea73137aaa7403a 
>   src/docker/docker.cpp 52728707d985517e57525af7e470ccb468039373 
> 
> Diff: https://reviews.apache.org/r/42516/diff/
> 
> 
> Testing
> -------
> 
> Using Swarm running on Mesos create a network with "docker  network create --driver=bridge
myNetwork"   and then create a container on that network:  "docker run --net=myNetwork...."
> 
> 
> Thanks,
> 
> Ezra Silvera
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message