mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Kevin Klues <klue...@gmail.com>
Subject Re: Review Request 43384: Improved error handling in generate-endpoint-help script.
Date Thu, 18 Feb 2016 19:52:14 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43384/#review119710
-----------------------------------------------------------




support/generate-endpoint-help.py (lines 295 - 299)
<https://reviews.apache.org/r/43384/#comment181052>

    I would exclude this.
    
    The stack trace should be more informative about what actually went wrong.



support/generate-endpoint-help.py (lines 313 - 317)
<https://reviews.apache.org/r/43384/#comment181051>

    I would exclude this.
    
    The stack trace should be more informative about what actually went wrong.



support/generate-endpoint-help.py (lines 324 - 332)
<https://reviews.apache.org/r/43384/#comment181054>

    This is clearly a bug and should be fixed as you have done.


- Kevin Klues


On Feb. 9, 2016, 10:43 p.m., Neil Conway wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43384/
> -----------------------------------------------------------
> 
> (Updated Feb. 9, 2016, 10:43 p.m.)
> 
> 
> Review request for mesos, Ben Mahler and Kevin Klues.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Two problems:
> 
>   (1) If the script exited when `current_subprocess` is None, it
>       would print an ugly exception stack trace.
> 
>   (2) If starting the Mesos master or agent failed, it would print
>       an ugly exception stack trace.
> 
> 
> Diffs
> -----
> 
>   support/generate-endpoint-help.py 28333847e5603c942f25ec9d9a0429bd676f4541 
> 
> Diff: https://reviews.apache.org/r/43384/diff/
> 
> 
> Testing
> -------
> 
> Ran the script in error and non-error cases with the changes applied.
> 
> 
> Thanks,
> 
> Neil Conway
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message