mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Cong Wang <xiyou.wangc...@gmail.com>
Subject Re: Review Request 43718: Added fs::supported() function.
Date Thu, 18 Feb 2016 17:43:22 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43718/#review119641
-----------------------------------------------------------




src/linux/fs.cpp (line 411)
<https://reviews.apache.org/r/43718/#comment180989>

    Use os::read() which handles error nicely.



src/linux/fs.cpp (line 413)
<https://reviews.apache.org/r/43718/#comment180990>

    Use tokenize("\n")


- Cong Wang


On Feb. 18, 2016, 4:01 p.m., Shuai Lin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43718/
> -----------------------------------------------------------
> 
> (Updated Feb. 18, 2016, 4:01 p.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Bugs: MESOS-4707
>     https://issues.apache.org/jira/browse/MESOS-4707
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added fs::supported() function.
> 
> 
> Diffs
> -----
> 
>   src/linux/fs.hpp fddee2441e008dc70d9cff5e63536ef21c865595 
>   src/linux/fs.cpp 0df194207a66bf4c417349bebcc8912acbf5976e 
>   src/tests/containerizer/fs_tests.cpp 29e43877612fa151e6f6d79268a7411272a7bfeb 
> 
> Diff: https://reviews.apache.org/r/43718/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Shuai Lin
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message