mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Klaus Ma <klaus1982...@gmail.com>
Subject Re: Review Request 43488: Adding framework capability for TASK_KILLING.
Date Tue, 16 Feb 2016 16:17:53 GMT


> On Feb. 16, 2016, 6:24 p.m., Klaus Ma wrote:
> > include/mesos/mesos.proto, line 261
> > <https://reviews.apache.org/r/43488/diff/2/?file=1241816#file1241816line261>
> >
> >     Do you mean framework can filter `killing` state? I thinke this's not necessary.
> 
> Abhishek Dasgupta wrote:
>     No. This is framework capability. We intend to use TASK_KILLING state when a killTask
is issued. So the framework that doesn't understand TASK_KILLING, for them only TASK_KILLED
will be issued. But the frameworks that has TASK_KILLING_STATE capability, for them TASK_KILLING
will be issued before a TASK_KILLED is issued.

I think you can sync up with shepherd on this. We add new task state `TASK_KILLING` and update
it to framework; if framework does not want to handle it, just ignore it. And in the following
patches, only docker and CLI executor are updated to handle this flag; how about other customer's
executor?


- Klaus


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43488/#review119288
-----------------------------------------------------------


On Feb. 16, 2016, 11:30 p.m., Abhishek Dasgupta wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43488/
> -----------------------------------------------------------
> 
> (Updated Feb. 16, 2016, 11:30 p.m.)
> 
> 
> Review request for mesos, Ben Mahler and Qian Zhang.
> 
> 
> Bugs: MESOS-4547
>     https://issues.apache.org/jira/browse/MESOS-4547
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Adding framework capability for TASK_KILLING.
> 
> 
> Diffs
> -----
> 
>   include/mesos/mesos.proto 5d1a20b4ff647f43701a353472b56a4b74b6bbc3 
>   include/mesos/v1/mesos.proto 415a20d9f3385e9627635dd89d78c58d03e3c116 
>   src/tests/master_tests.cpp 393a6f5fe3744d6ba743f362b7e309d1ee75a303 
> 
> Diff: https://reviews.apache.org/r/43488/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Abhishek Dasgupta
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message