mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Ezra Silvera <e...@il.ibm.com>
Subject Re: Review Request 42516: Add support for user-defined networks.
Date Tue, 16 Feb 2016 12:38:57 GMT


> On Feb. 16, 2016, 4:04 a.m., Timothy Chen wrote:
> > Thinking about it a bit more I think it's fine without a unit test as it requires
docker network create. Did you test this manually and made sure it worked?
> > Once you update the comments I can merge it.

I fixed all the typos and committed the changes.  BTW, I rebased my code to the latest mesos
code here:

https://github.com/ezrasilvera/mesos/tree/dockerUserNetwork

We tested the code against Docker 1.8.0 and got the excepted error (require version greater
then 1.9.0) and  verified that it's working against Docker 1.9.0 and 1.10 
Once you merge it we can also go ahead and make the needed changes in SWARM to support this.


- Ezra


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42516/#review119266
-----------------------------------------------------------


On Feb. 11, 2016, 1:51 p.m., Ezra Silvera wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42516/
> -----------------------------------------------------------
> 
> (Updated Feb. 11, 2016, 1:51 p.m.)
> 
> 
> Review request for mesos and Timothy Chen.
> 
> 
> Bugs: MESOS-4369
>     https://issues.apache.org/jira/browse/MESOS-4369
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Signed-off-by: Ezra Silvera <ezra@il.ibm.com>
> 
> 
> Diffs
> -----
> 
>   include/mesos/mesos.proto 5d1a20b4ff647f43701a353472b56a4b74b6bbc3 
>   include/mesos/v1/mesos.proto 415a20d9f3385e9627635dd89d78c58d03e3c116 
>   src/docker/docker.cpp 52728707d985517e57525af7e470ccb468039373 
> 
> Diff: https://reviews.apache.org/r/42516/diff/
> 
> 
> Testing
> -------
> 
> Using Swarm running on Mesos create a network with "docker  network create --driver=bridge
myNetwork"   and then create a container on that network:  "docker run --net=myNetwork...."
> 
> 
> Thanks,
> 
> Ezra Silvera
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message