mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mesos ReviewBot <revi...@mesos.apache.org>
Subject Re: Review Request 43367: Speed up FetcherCache test cases by reduce allocation_interval.
Date Tue, 16 Feb 2016 12:22:34 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43367/#review119303
-----------------------------------------------------------



Patch looks great!

Reviews applied: [42696, 43316, 43367]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' COMPILER='gcc' ENVIRONMENT='GLOG_v=1
MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On Feb. 16, 2016, 11:42 a.m., haosdent huang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43367/
> -----------------------------------------------------------
> 
> (Updated Feb. 16, 2016, 11:42 a.m.)
> 
> 
> Review request for mesos and Bernd Mathiske.
> 
> 
> Bugs: MESOS-4628
>     https://issues.apache.org/jira/browse/MESOS-4628
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Speed up FetcherCache test cases by advance allocation_interval.
> 
> 
> Diffs
> -----
> 
>   src/tests/fetcher_cache_tests.cpp 1cf45660691860793ac600363f7934e13a2e7ddf 
> 
> Diff: https://reviews.apache.org/r/43367/diff/
> 
> 
> Testing
> -------
> 
> Before this patch:
> ```
> [       OK ] FetcherCacheTest.LocalUncached (1065 ms)
> [       OK ] FetcherCacheTest.LocalCached (1728 ms)
> [       OK ] FetcherCacheTest.CachedFallback (1105 ms)
> [       OK ] FetcherCacheTest.LocalUncachedExtract (906 ms)
> [       OK ] FetcherCacheTest.LocalCachedExtract (1715 ms)
> [       OK ] FetcherCacheTest.SimpleEviction (3626 ms)
> [       OK ] FetcherCacheTest.FallbackFromEviction (2649 ms)
> [       OK ] FetcherCacheTest.RemoveLRUCacheEntries (3639 ms)
> [       OK ] FetcherCacheHttpTest.HttpCachedSerialized (2608 ms)
> [       OK ] FetcherCacheHttpTest.HttpCachedConcurrent (1529 ms)
> [       OK ] FetcherCacheHttpTest.HttpMixed (1349 ms)
> ```
> 
> After this patch:
> ```
> [       OK ] FetcherCacheTest.LocalUncached (984 ms)
> [       OK ] FetcherCacheTest.LocalCached (1750 ms)
> [       OK ] FetcherCacheTest.CachedFallback (1043 ms)
> [       OK ] FetcherCacheTest.LocalUncachedExtract (1006 ms)
> [       OK ] FetcherCacheTest.LocalCachedExtract (1714 ms)
> [       OK ] FetcherCacheTest.SimpleEviction (2723 ms)
> [       OK ] FetcherCacheTest.FallbackFromEviction (2220 ms)
> [       OK ] FetcherCacheTest.RemoveLRUCacheEntries (2736 ms)
> [       OK ] FetcherCacheHttpTest.HttpCachedSerialized (2251 ms)
> [       OK ] FetcherCacheHttpTest.HttpCachedConcurrent (1514 ms)
> [       OK ] FetcherCacheHttpTest.HttpMixed (1209 ms)
> ```
> 
> 
> Thanks,
> 
> haosdent huang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message