mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jian Qiu <qiuj...@cn.ibm.com>
Subject Re: Review Request 43041: Update Master to send revocable resources in separate offers.
Date Tue, 16 Feb 2016 08:33:08 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43041/#review119273
-----------------------------------------------------------




src/master/master.cpp (line 5281)
<https://reviews.apache.org/r/43041/#comment180585>

    How about
    
    if (revocableResource != offered) {
      Offer offer = createOffer(framework, slave, offered - revocableResource)
      ...
    }
    
    if (!revocableResource.empty()) {
      Offer offer = createOffer(framework, slave, revocableResource)
    }


- Jian Qiu


On 二月 16, 2016, 8:21 a.m., Yongqiao Wang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43041/
> -----------------------------------------------------------
> 
> (Updated 二月 16, 2016, 8:21 a.m.)
> 
> 
> Review request for mesos, Guangya Liu, Klaus Ma, Niklas Nielsen, Qian Zhang, Jian Qiu,
and Vinod Kone.
> 
> 
> Bugs: MESOS-2646
>     https://issues.apache.org/jira/browse/MESOS-2646
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Update Master to send revocable resources in separate offers.
> 
> 
> Diffs
> -----
> 
>   src/master/master.hpp 2f2ad2ada508e1923bf995ab124367a3b082b572 
>   src/master/master.cpp e1ca81dab85a7ab1391eca0d6bd995548bf79c22 
>   src/tests/oversubscription_tests.cpp d4ae81972fd218c58a413d1968a4e9acbee52fd3 
> 
> Diff: https://reviews.apache.org/r/43041/diff/
> 
> 
> Testing
> -------
> 
> Make && Make check
>  
> Test: https://reviews.apache.org/r/43593/
> 
> 
> Thanks,
> 
> Yongqiao Wang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message