mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Abhishek Dasgupta <a10gu...@linux.vnet.ibm.com>
Subject Re: Review Request 43490: Added testcase for TASK_KILLING state.
Date Tue, 16 Feb 2016 08:30:06 GMT


> On Feb. 12, 2016, 10:50 a.m., Guangya Liu wrote:
> > src/tests/scheduler_tests.cpp, lines 476-483
> > <https://reviews.apache.org/r/43490/diff/1/?file=1240313#file1240313line476>
> >
> >     I think that this case cannot cover the case of framework capabaility `TASK_KILLING_STATE`,
what about update one framework to enable this framework can handle the capability of `TASK_KILLING_STATE`?

> >     
> >     Such as https://github.com/apache/mesos/blob/master/src/examples/no_executor_framework.cpp#L357-L360

Updated the test case to test framework capability.


- Abhishek


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43490/#review118992
-----------------------------------------------------------


On Feb. 16, 2016, 8:29 a.m., Abhishek Dasgupta wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43490/
> -----------------------------------------------------------
> 
> (Updated Feb. 16, 2016, 8:29 a.m.)
> 
> 
> Review request for mesos, Ben Mahler and Qian Zhang.
> 
> 
> Bugs: MESOS-4547
>     https://issues.apache.org/jira/browse/MESOS-4547
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added testcase for TASK_KILLING state.
> 
> 
> Diffs
> -----
> 
>   src/tests/mesos.hpp c0997dbacf8753149caba0a8b2406afc35a4845f 
>   src/tests/scheduler_tests.cpp 37f17094b3f11fd02468bf51b51b8e65ccb350a9 
> 
> Diff: https://reviews.apache.org/r/43490/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Abhishek Dasgupta
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message