mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Yongqiao Wang <yq...@cn.ibm.com>
Subject Re: Review Request 42719: Add doc for weights.
Date Sun, 14 Feb 2016 12:45:44 GMT


> On Feb. 10, 2016, 9:03 a.m., Adam B wrote:
> > Looks good, but I think we can pull this information into the roles.md and endpoint
help docs, rather than create a new docs page.

Maybe weight will also be supported for framework in the future, so I think it is better to
create a new doc for weights.


> On Feb. 10, 2016, 9:03 a.m., Adam B wrote:
> > docs/weights.md, line 5
> > <https://reviews.apache.org/r/42719/diff/1/?file=1219343#file1219343line5>
> >
> >     Why not just include this in the existing roles.md?
> >     If you are creating a new doc, you ought to add it to home.md so it can easily
be found and navigated to.

I considered that weight will also be support for framework, so I created a new doc for that.


> On Feb. 10, 2016, 9:03 a.m., Adam B wrote:
> > docs/weights.md, line 19
> > <https://reviews.apache.org/r/42719/diff/1/?file=1219343#file1219343line19>
> >
> >     I wonder if all this information should just go in the endpoint help description,
and then you can link to it in the new auto-generated endpoints docs, e.g. http://mesos.apache.org/documentation/latest/endpoints/master/roles/

The /weights endpoint help description will be auto-generated from strings stored in the Mesos
source code, so if we still decide to create a new doc for weights, then does not need to
add this link.


- Yongqiao


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42719/#review118617
-----------------------------------------------------------


On Jan. 25, 2016, 3 p.m., Yongqiao Wang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42719/
> -----------------------------------------------------------
> 
> (Updated Jan. 25, 2016, 3 p.m.)
> 
> 
> Review request for mesos and Adam B.
> 
> 
> Bugs: MESOS-3945
>     https://issues.apache.org/jira/browse/MESOS-3945
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Add doc for weights.
> 
> 
> Diffs
> -----
> 
>   docs/weights.md PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/42719/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Yongqiao Wang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message