mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Travis Hegner <travis.heg...@gmail.com>
Subject Re: Review Request 42516: Add support for user-defined networks.
Date Fri, 12 Feb 2016 16:56:41 GMT


> On Feb. 12, 2016, 3:25 p.m., Travis Hegner wrote:
> > Please have a look at https://reviews.apache.org/r/43093/. Should these patches
be combined, or worked on together? Adding support for user defined networks, should also
include support for proper IP address detection via those networks yes? Docker 1.9.0 not only
introduced user defined networks, it also introduced custom network drivers and deprecated
the existing "NetworkSettings.IPAddress" field which mesos uses to identify the container's
IP.
> 
> Ezra Silvera wrote:
>     We can add the change into our patch as we are already doing all the relevant checks
+ defined a dedicated new field for the network name. 
>     We would simply use "NetworkSettings.Networks.<network_name>.IPAddress for
docker version >= 1.9 ..   I'll push another commit shortly.
>     Is that OK ?

That would be fantastic. My code was not yet fully baked, so hopefully it doesn't hinder your
progress too much here. I'd be happy to help with the review proces, but I won't be available
until Monday to do so.

Also, somewhat unrelated, but I've noticed that when health checks are enabled for a docker
container, it seems to change the detected IPAddress for that container. Perhaps there is
another execution path somewhere that does IP detection with different code? I've only just
started investigating that issue, and don't have much more info than that, so feel free to
ignore that part until I can investigate further.


- Travis


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42516/#review119031
-----------------------------------------------------------


On Feb. 11, 2016, 1:51 p.m., Ezra Silvera wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42516/
> -----------------------------------------------------------
> 
> (Updated Feb. 11, 2016, 1:51 p.m.)
> 
> 
> Review request for mesos and Timothy Chen.
> 
> 
> Bugs: MESOS-4369
>     https://issues.apache.org/jira/browse/MESOS-4369
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Signed-off-by: Ezra Silvera <ezra@il.ibm.com>
> 
> 
> Diffs
> -----
> 
>   include/mesos/mesos.proto 5d1a20b4ff647f43701a353472b56a4b74b6bbc3 
>   include/mesos/v1/mesos.proto 415a20d9f3385e9627635dd89d78c58d03e3c116 
>   src/docker/docker.cpp 52728707d985517e57525af7e470ccb468039373 
> 
> Diff: https://reviews.apache.org/r/42516/diff/
> 
> 
> Testing
> -------
> 
> Using Swarm running on Mesos create a network with "docker  network create --driver=bridge
myNetwork"   and then create a container on that network:  "docker run --net=myNetwork...."
> 
> 
> Thanks,
> 
> Ezra Silvera
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message