mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Klaus Ma <klaus1982...@gmail.com>
Subject Re: Review Request 41305: MESOS-1718: move getExecutorInfo from slave to master.
Date Fri, 12 Feb 2016 15:15:14 GMT


> On Jan. 22, 2016, 5:37 a.m., Joseph Wu wrote:
> > src/master/master.cpp, line 2860
> > <https://reviews.apache.org/r/41305/diff/3/?file=1200898#file1200898line2860>
> >
> >     `launcher_dir` is an optional field.
> >     
> >     Same for the other fields you added (`sandbox_dir`, `switch_user`, `executor_rootfs).

@Joseph, do you mean we need to check whether the value is set? I think it's also related
with compatibility with old slave, we should also handle it when old slave did not report
`slaveInfo`, right?


- Klaus


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41305/#review115703
-----------------------------------------------------------


On Feb. 12, 2016, 11:02 p.m., Klaus Ma wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41305/
> -----------------------------------------------------------
> 
> (Updated Feb. 12, 2016, 11:02 p.m.)
> 
> 
> Review request for mesos, Ben Mahler and Joseph Wu.
> 
> 
> Bugs: MESOS-1718
>     https://issues.apache.org/jira/browse/MESOS-1718
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> MESOS-1718: move getExecutorInfo from slave to master
> 
> 
> Diffs
> -----
> 
>   src/master/constants.hpp 2c3299bc1aaa0888f7e47a71965c56ada8ecc21f 
>   src/master/master.hpp 3a7e18232323a1c051bcc97915484b1195fffe58 
>   src/master/master.cpp 9ee56277c8a472be9e683d5db505becfb5f7c422 
>   src/slave/constants.hpp bcbb1401aa8f9f04c4f9256bb4f560e18d8994e0 
>   src/slave/slave.hpp b7586ce42bfac9d9885a3eb8d82deb94680c236c 
>   src/slave/slave.cpp bb501810d7bb1261ebbbdd147c49948e5a2f8665 
> 
> Diff: https://reviews.apache.org/r/41305/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Klaus Ma
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message