mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joseph Wu <>
Subject Review Request 43447: Update monitoring tests to pass shared_ptrs to 'StartSlave'.
Date Wed, 10 Feb 2016 23:36:11 GMT

This is an automatically generated e-mail. To reply, visit:

Review request for mesos, Bernd Mathiske and Artem Harutyunyan.

Bugs: MESOS-4633

Repository: mesos


Makes the following changes:

* All objects passed to `StartSlave` are transformed into `shared_ptr`.
* References to the above objects are updated to reflect the different type.
* Removes `Shutdown()` in at the end of all tests, except for master tests that have a stack-allocated
* Removes manual `delete`s inside tests.
* Generally renames test variables to be more consistent (i.e. `exec` -> `executor` and
`dockerContainerizer` -> `containerizer`).
* Removes extraneous spaces in `Try<PID<Slave> >` in touched lines.


  src/tests/health_check_tests.cpp 59ef31970af2d255abe169dfbc2e6e0314d29e9a 
  src/tests/monitor_tests.cpp 869c9e032817e8859a968232d4a61556a3d53d45 
  src/tests/rate_limiting_tests.cpp caced732ded05a334861a53488ef6391885b2263 
  src/tests/status_update_manager_tests.cpp d64d3b8c96270478f6b681c038de77c3a9eb68fe 



Tests are run at the very, very end of this review chain.


Joseph Wu

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message