mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joseph Wu <>
Subject Review Request 43445: Update recovery tests to pass shared_ptrs to 'StartSlave'.
Date Wed, 10 Feb 2016 23:36:08 GMT

This is an automatically generated e-mail. To reply, visit:

Review request for mesos, Bernd Mathiske and Artem Harutyunyan.

Bugs: MESOS-4633

Repository: mesos


Makes the following changes:

* All objects passed to `StartSlave` are transformed into `shared_ptr`.
* References to the above objects are updated to reflect the different type.
* Removes `Shutdown()` in at the end of all tests, except for master tests that have a stack-allocated
* Removes manual `delete`s inside tests.
* Generally renames test variables to be more consistent (i.e. `exec` -> `executor` and
`dockerContainerizer` -> `containerizer`).
* Removes extraneous spaces in `Try<PID<Slave> >` in touched lines.


  src/tests/fault_tolerance_tests.cpp 982468f851cd9d95eb6cde7c57f2d737d46a827c 
  src/tests/partition_tests.cpp c5badbe90e302793bfbf3f16373efe241decb7d5 
  src/tests/reconciliation_tests.cpp 97112c4d64c75a16fdd7bbefd517a039fbf55b64 
  src/tests/repair_tests.cpp bb104562659e135492f9857e5b452c8a0a9e97da 



Tests are run at the very, very end of this review chain.


Joseph Wu

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message