mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joseph Wu <jos...@mesosphere.io>
Subject Re: Review Request 43305: Moved systemd executor slice initialization logic.
Date Wed, 10 Feb 2016 22:11:17 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43305/#review118733
-----------------------------------------------------------




src/slave/containerizer/mesos/linux_launcher.cpp 
<https://reviews.apache.org/r/43305/#comment180035>

    Looks like this breaks the `CGROUPS_ROOT_*` tests.  I'll have a patch up shortly to address
this:
    
    https://reviews.apache.org/r/43432/


- Joseph Wu


On Feb. 10, 2016, 8:50 a.m., Joris Van Remoortere wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43305/
> -----------------------------------------------------------
> 
> (Updated Feb. 10, 2016, 8:50 a.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Jie Yu.
> 
> 
> Bugs: MESOS-4636
>     https://issues.apache.org/jira/browse/MESOS-4636
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Moved systemd executor slice initialization logic.
> 
> 
> Diffs
> -----
> 
>   src/linux/systemd.hpp dc8605b323cafdc0dde00d36a2cc5cf2c241e51c 
>   src/linux/systemd.cpp 5034308cb4d1bb0b66c097daf5ec53a880cf510a 
>   src/slave/containerizer/mesos/linux_launcher.hpp b061981b063a67d837fe8e291921ca9c44d3ac40

>   src/slave/containerizer/mesos/linux_launcher.cpp c2e252ec6ed0d6d4c47e244f700315bd340cee5f

>   src/slave/main.cpp 22b833044dc3f900e3b5ea509e6e545148649f48 
> 
> Diff: https://reviews.apache.org/r/43305/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Joris Van Remoortere
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message