mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Neil Conway <neil.con...@gmail.com>
Subject Re: Review Request 43388: Revised authentication documentation.
Date Wed, 10 Feb 2016 18:28:59 GMT


> On Feb. 10, 2016, 3:04 a.m., Guangya Liu wrote:
> > docs/authentication.md, line 65
> > <https://reviews.apache.org/r/43388/diff/3/?file=1239198#file1239198line65>
> >
> >     The MESOS-2281 is planning to remove the JSON format credential, does it make
sense to remove the `JSON format` here as the `plaintext` is the recommended format.

I'm inclined to leave this as-is: we talk about both formats elsewhere, e.g., in `--help`
output and in `configuration.md`. If/when we remove/deprecate the JSON format, we should update
all those places accordingly.


- Neil


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43388/#review118556
-----------------------------------------------------------


On Feb. 10, 2016, 2:06 a.m., Neil Conway wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43388/
> -----------------------------------------------------------
> 
> (Updated Feb. 10, 2016, 2:06 a.m.)
> 
> 
> Review request for mesos, Adam B, Greg Mann, and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Revised authentication documentation.
> 
> 
> Diffs
> -----
> 
>   docs/authentication.md b40b09eaceddc8e5498b54b3e8ef7a5dbd7b9dc2 
> 
> Diff: https://reviews.apache.org/r/43388/diff/
> 
> 
> Testing
> -------
> 
> Previewed in site-docker.
> 
> 
> Thanks,
> 
> Neil Conway
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message