mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Avinash sridharan <avin...@mesosphere.io>
Subject Re: Review Request 43323: Added unit-test for checking `NetCls` classid in `state.json.
Date Wed, 10 Feb 2016 06:50:50 GMT


> On Feb. 10, 2016, 1:26 a.m., Jie Yu wrote:
> > src/tests/containerizer/isolator_tests.cpp, line 1089
> > <https://reviews.apache.org/r/43323/diff/1/?file=1237118#file1237118line1089>
> >
> >     Can you do
> >     ```
> >     namespace http = process::http;
> >     ```
> >     in the begining so that you can do
> >     ```
> >     http::get(...)
> >     ```
> >     here

We already have using namespace process in `isolator_tests.cpp`, so we can directly use http::get
. This is not strictly according to the coding guidelines, should we make the `using` clause
more explicit ?


- Avinash


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43323/#review118532
-----------------------------------------------------------


On Feb. 10, 2016, 6:49 a.m., Avinash sridharan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43323/
> -----------------------------------------------------------
> 
> (Updated Feb. 10, 2016, 6:49 a.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Bugs: MESOS-4358
>     https://issues.apache.org/jira/browse/MESOS-4358
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added a test-case to check that the agent is able to retrieve the
> `ContainerStatus` successfully from the containerizer (and therefore
> the isolators), and expose it in its `state.json`.
> 
> 
> Diffs
> -----
> 
>   src/tests/containerizer/isolator_tests.cpp 84fe4fb61ac032e68d2ab22e85f6b41481c04644

> 
> Diff: https://reviews.apache.org/r/43323/diff/
> 
> 
> Testing
> -------
> 
> make, make check, and sudo ./build/mesos-tests.sh
> 
> 
> Thanks,
> 
> Avinash sridharan
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message