mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mesos ReviewBot <revi...@mesos.apache.org>
Subject Re: Review Request 43240: Removed implicit, value changing conversion.
Date Fri, 05 Feb 2016 19:57:47 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43240/#review118067
-----------------------------------------------------------



Patch looks great!

Reviews applied: [43240]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' COMPILER='gcc' ENVIRONMENT='GLOG_v=1
MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On Feb. 5, 2016, 5:41 p.m., Benjamin Bannier wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43240/
> -----------------------------------------------------------
> 
> (Updated Feb. 5, 2016, 5:41 p.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Whether `char` is signed or not is up to the implementation, so be more explicit
> here. Also, since we want a `char` with all bits set, use a value representation
> that more clearly communicates that.
> 
> 
> Diffs
> -----
> 
>   src/log/tool/benchmark.cpp 9cb60bd66f53e0d191d96a429bfca89d91412339 
> 
> Diff: https://reviews.apache.org/r/43240/diff/
> 
> 
> Testing
> -------
> 
> When compiling with trunk clang, compilation fails with
> 
>     ../../src/log/tool/benchmark.cpp|209 col 47 warning| implicit conversion from 'int'
to 'value_type' (aka 'char') changes value from 255 to -1 [-Wconstant-conversion]
>     
> After inserting the explicit cast the code compiles fine.
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message