mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Michael Park <mp...@apache.org>
Subject Re: Review Request 42616: Cleaned up usage of namespace-qualified identifiers in libprocess.
Date Thu, 04 Feb 2016 02:12:32 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42616/#review117747
-----------------------------------------------------------


Ship it!




Ship It!

- Michael Park


On Feb. 1, 2016, 10:07 p.m., Neil Conway wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42616/
> -----------------------------------------------------------
> 
> (Updated Feb. 1, 2016, 10:07 p.m.)
> 
> 
> Review request for mesos and Michael Park.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> For example, avoid using `std::string` in a .cpp file that already does
> `using std::string`.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/src/authenticator.cpp 16b48cd599b10c09229fbf10f28139219855710b

>   3rdparty/libprocess/src/http.cpp 762da9a9038fc0a81156b5c03b556084df1bd7e0 
>   3rdparty/libprocess/src/io.cpp 9530192e2c7afbfa4bd9aa2af2ff40f00ee505a9 
>   3rdparty/libprocess/src/libevent_ssl_socket.cpp 9321ce666a0c5c75cdbdd1c5a6d534fbc221bf5b

>   3rdparty/libprocess/src/metrics/metrics.cpp 3083b92b3fb67421265950b03272b52cec68daf9

>   3rdparty/libprocess/src/pid.cpp 3cd04ecaddd045d9d5ecf132302417181d416f80 
>   3rdparty/libprocess/src/process.cpp d8a74d7637d20c81f384e974e4fdeba22effb437 
>   3rdparty/libprocess/src/socket.cpp 6c1b16f69a21d116a0ffef21097a1b4372977b2e 
>   3rdparty/libprocess/src/tests/process_tests.cpp df1c7b3f37ab1103991a4f27a9e0359bcf06cc68

> 
> Diff: https://reviews.apache.org/r/42616/diff/
> 
> 
> Testing
> -------
> 
> "make check" on OSX and Arch Linux.
> 
> 
> Thanks,
> 
> Neil Conway
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message