mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jie Yu <yujie....@gmail.com>
Subject Re: Review Request 42781: Added the --cgroups_net_cls_primary_handle flag to the slave.
Date Wed, 03 Feb 2016 20:12:58 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42781/#review117668
-----------------------------------------------------------




src/slave/constants.cpp (line 55)
<https://reviews.apache.org/r/42781/#comment178940>

    I am thinking about whether we should introduce a default here or not.
    
    I think I also want the option that Mesos will just do the cgroups creation without assigning
handles.
    
    That being said, can we make the flag optional and do not assign handles in net_cls cgroup
if that flag is not set?


- Jie Yu


On Feb. 3, 2016, 7:47 a.m., Avinash sridharan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42781/
> -----------------------------------------------------------
> 
> (Updated Feb. 3, 2016, 7:47 a.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Bugs: MESOS-4344
>     https://issues.apache.org/jira/browse/MESOS-4344
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added the --cgroups_net_cls_primary_handle flag to the slave.
> 
> 
> Diffs
> -----
> 
>   src/slave/constants.hpp bcbb1401aa8f9f04c4f9256bb4f560e18d8994e0 
>   src/slave/constants.cpp 0f0d8e4b079d136d250f83cfc768de8c98b8bee2 
>   src/slave/flags.hpp 23ec158f4a95fa76d657d9eb6a4a6fe30d57e5b6 
>   src/slave/flags.cpp 24a23325cc255d0d7b7af7ed096b6d3012ad75c7 
> 
> Diff: https://reviews.apache.org/r/42781/diff/
> 
> 
> Testing
> -------
> 
> Tested the flag by launching a mesos agent and checking that the slave takes the `--cgroups_net_cls_major_handles`
flag.
> 
> 
> Thanks,
> 
> Avinash sridharan
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message