mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Alexander Rukletsov <>
Subject Re: Review Request 42908: Fixed a flaky test in quota tests.
Date Fri, 29 Jan 2016 10:34:36 GMT

This is an automatically generated e-mail. To reply, visit:

(Updated Jan. 29, 2016, 10:34 a.m.)

Review request for mesos, Michael Park and Qian Zhang.


Addressed Klaus' comment.

Bugs: MESOS-4542

Repository: mesos


The `AvailableResourcesAfterRescinding` test became flaky after we
stopped offering unreserved resources beyond quota in Hence the allocator offers
rescinded resources to `framework1` if an allocation happens before
the test finishes, which violates the expectation that `framework1`
receives resources only once. Since we do not really care about
allocations in this test but rather about rescinded resources, the
fix is just to ignore subsequent offers to `framework1`.

Diffs (updated)

  src/tests/master_quota_tests.cpp 04efcf3362d3594e0ad8077793fa1f32536dd658 



On Mac OS 10.10.4:
`GTEST_FILTER="MasterQuotaTest.AvailableResourcesAfterRescinding" ./bin/ --gtest_shuffle
--gtest_break_on_failure --gtest_repeat=5000`


Alexander Rukletsov

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message