mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joseph Wu <>
Subject Re: Review Request 41783: Logger Module: Implement the rotating container logger module.
Date Sat, 23 Jan 2016 09:07:15 GMT

This is an automatically generated e-mail. To reply, visit:

(Updated Jan. 23, 2016, 1:07 a.m.)

Review request for mesos, Benjamin Hindman and Artem Harutyunyan.


Cleaned up some headers.
Refactored `logrotate.cpp` a little (BenH's suggestions).
Added quotation marks inside the `logrotate` command and configuration file.
Added a `setsid` call such that the logger subprocess will not exit if the agent terminates.

Bugs: MESOS-4136

Repository: mesos


Adds a non-default ContainerLogger that constrains total log size by rotating logs (i.e. renaming
the head log file).

Diffs (updated)

  src/slave/container_loggers/lib_logrotate.hpp PRE-CREATION 
  src/slave/container_loggers/lib_logrotate.cpp PRE-CREATION 
  src/slave/container_loggers/logrotate.hpp PRE-CREATION 
  src/slave/container_loggers/logrotate.cpp PRE-CREATION 



make check


Joseph Wu

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message