mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Greg Mann" <>
Subject Re: Review Request 42362: Added persistent volume endpoint test without authentication.
Date Fri, 22 Jan 2016 17:03:04 GMT

This is an automatically generated e-mail. To reply, visit:

(Updated Jan. 22, 2016, 5:03 p.m.)

Review request for mesos, Alexander Rukletsov, Michael Park, and Neil Conway.


Removed extraneous test cases.

Bugs: MESOS-4395

Repository: mesos


Added persistent volume endpoint tests with HTTP authentication disabled, both with and without
authorization enabled.

The persistent volume endpoint tests allow volume creation and destruction without authorization
and without a principal; this patch introduces test cases for this scenario: `PersistentVolumeEndpointsTest.NoAuthenticationNoAuthorization`
and `PersistentVolumeEndpointsTest.NoAuthenticationWithAuthorization`. NOTE: due to the current
behavior of the HTTP authentication code, when HTTP authentication is disabled, the endpoint
callbacks always receive a principal of `None()`, which means that authorization cannot be
properly used when HTTP authentication is disabled.

Diffs (updated)

  src/tests/persistent_volume_endpoints_tests.cpp 22e18758ee91a649486725473d9e50fae9d43b01



A new test, `PersistentVolumeEndpointsTest.NoAuthorization`, was added to the persistent volume
endpoint tests.

`make check` was used to test, and the new test was run with `--gtest_repeat=1000 -gtest_break_on_failure=1`.


Greg Mann

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message