mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bernd Mathiske" <>
Subject Re: Review Request 42149: Replaced mutex in HTTP server for fetcher cache tests with latch.
Date Mon, 18 Jan 2016 11:28:38 GMT

This is an automatically generated e-mail. To reply, visit:

(Updated Jan. 18, 2016, 3:28 a.m.)

Review request for mesos, Adam B, Alexander Rojas, Benjamin Hindman, Joseph Wu, Till Toenshoff,
and Timothy Chen.


Addressed Alexander's review. Now conforming with standard pattern of "provide()" in "initialize()".

Bugs: MESOS-3235

Repository: mesos


Also inlined the function that awaits fetch contention.

This mutex was prone to causing races at task startup by firmly
blocking an internal libprocess thread. The latch avoids this.

Failing to launch a task due to such a race did not get flagged
by directly related test failures, because the AWAIT catching this
situation was ineffective, having been placed inside a call from the
test. Only the subsequent wait for task completion triggered a test
failure then. By then it was obscured what exactly had happened.

Diffs (updated)

  src/tests/fetcher_cache_tests.cpp 1fb1e213d3c35479789688d1a3a49a3c6058b198 



make check
bin/ --gtest_repeat=1000 --gtest_break_on_failure --gtest_filter="*HttpCachedConcurrent*"


Bernd Mathiske

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message