mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alexander Rojas" <>
Subject Re: Review Request 42140: Removed deprecated constructor of http::Unauthorized in Mesos.
Date Mon, 18 Jan 2016 10:53:05 GMT

This is an automatically generated e-mail. To reply, visit:

(Updated Jan. 18, 2016, 11:53 a.m.)

Review request for mesos, Benjamin Bannier, Ben Mahler, Jan Schlicht, and Till Toenshoff.



Bugs: MESOS-3933 and MESOS-4305

Repository: mesos


The constructor of `process::http::Unauthorized(const std::string&)` is marked as deprecated.
This patch fully removes the constructor and cleans up its usage in the Mesos codebase.

This change also allows to use initializer lists on the `process::http::Unauthorized(const
std::vector<std::string>&)` constructor since there is no longer an ambiguity.

Diffs (updated)

  src/tests/http_authentication_tests.cpp 3d6da53b8d6b4f0d3e5631a1855983583c0ae7dc 
  src/tests/master_quota_tests.cpp e8cb074c2913cafdc6b1792896f29e53f1210c9d 
  src/tests/persistent_volume_endpoints_tests.cpp f0cce190abc90f0fae84d6c3db20e8215c2d8132

  src/tests/reservation_endpoints_tests.cpp b8edd6fafedd4c2221a8d19c1ebc71254071a8c7 
  src/tests/teardown_tests.cpp 97cc89ba168aefff8512f6d1a25c4f7ddf180bae 



make check


Alexander Rojas

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message