mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Greg Mann" <>
Subject Re: Review Request 42215: Added expectations for a shutdown call in ReservationTests.
Date Wed, 13 Jan 2016 21:37:50 GMT

This is an automatically generated e-mail. To reply, visit:

(Updated Jan. 13, 2016, 9:37 p.m.)

Review request for mesos, Neil Conway and Timothy Chen.


Added test names to the description.

Bugs: MESOS-4347

Repository: mesos

Description (updated)

Added expectations for call to mocked executor shutdown. The mock executor's shutdown method
sometimes gets executed before the test exits, so it should be explicitly expected. Expectations
were added to ReservationTest.ReserveAndLaunchThenUnreserve, ReservationTest.CompatibleCheckpointedResources,
ReservationTest.CompatibleCheckpointedResourcesWithPersistentVolumes, ReservationTest.IncompatibleCheckpointedResources,
and ReservationTest.ACLMultipleOperations.


  src/tests/reservation_tests.cpp 61d275c47fbb02baf22e4ad8f9b1580886da51d9 



I used `GTEST_FILTER="ReservationTest.*" bin/ --gtest_repeat=10000 --gtest_break_on_failure=1
| grep -B 3 -A 6 WARNING` to reproduce the warnings, and then to verify that they were gone
after the fix. Note that when running this command after the patch, other warning may be seen
due to


Greg Mann

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message