mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Kevin Klues" <>
Subject Re: Review Request 42212: Added unit test for framework/task history flags.
Date Wed, 13 Jan 2016 11:01:41 GMT

This is an automatically generated e-mail. To reply, visit:

(Updated Jan. 13, 2016, 11:01 a.m.)

Review request for mesos and Ben Mahler.


Change EXPECT_LE to EXPECT_EQ for comparing maxFrameworks/numFrameworks and maxTasksPerFramework/numTaskPerFramework.
This change is OK, and actually more correct given the setup of the test (i.e. we will always
be limited by max*). Also fix up some comments.

Bugs: MESOS-3307

Repository: mesos


This commit adds a unit test to verify that the the max_frameworks and
max_tasks_per_frameworks flags for master work properly. Specifically,
we test to verify that the proper amount of history is maintained for
both 0 values to these flags as well as positive values <= to the total
number frameworks and tasks per framework actually launched.

Diffs (updated)

  src/tests/master_tests.cpp 223b9d20a3a8a8194a3a6a605ec2394c37ab5957 



This is a unit test.  I ran it on my mac and on ubuntu 14.04.

GTEST_FILTER="MasterTest.FrameworksTasksCompletedFlags" make check -j 7


Kevin Klues

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message