mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bernd Mathiske" <>
Subject Review Request 42149: Replaced mutex in HTTP server for fetcher cache tests with latch. Inlined awaiting fetch contention.
Date Mon, 11 Jan 2016 17:15:13 GMT

This is an automatically generated e-mail. To reply, visit:

Review request for mesos, Alexander Rojas, Jie Yu, Joseph Wu, Neil Conway, and Till Toenshoff.

Bugs: MESOS-3235

Repository: mesos


This mutex was prone to causing races at task startup by firmly
blocking an internal libprocess thread. The latch avoids this.

Failing to launch a task due to such a race did not get flagged
by directly related test failures, because the AWAIT catching this
situation was ineffective, having been placed inside a call from the
test. Only the subsequent wait for task completion triggered a test
failure then. By then it was obscured what exactly had happened.


  src/tests/fetcher_cache_tests.cpp 1fb1e213d3c35479789688d1a3a49a3c6058b198 



make check
bin/ --gtest_repeat=1000 --gtest_break_on_failure --gtest_filter="*HttpCachedConcurrent*"


Bernd Mathiske

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message