mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alexander Rojas" <>
Subject Re: Review Request 38950: Http Authenticators can be loaded as modules from mesos.
Date Tue, 05 Jan 2016 16:17:53 GMT

This is an automatically generated e-mail. To reply, visit:

(Updated Jan. 5, 2016, 5:17 p.m.)

Review request for mesos, Adam B, Bernd Mathiske, and Till Toenshoff.


Fixed a wrong static function declaration.

Bugs: MESOS-3756

Repository: mesos


Adds support for modularization of HTTP Authenticators. 

It includes an example of how to do it with the Basic HTTP Authenticator.

Diffs (updated)

  include/mesos/authentication/http/basic_authenticator_factory.hpp PRE-CREATION 
  include/mesos/module/http_authenticator.hpp PRE-CREATION 
  src/CMakeLists.txt 8169fe4f1a0eda5c2e2b30e22a7346478420a9a0 
  src/ e08e86724abaa3023f0483aa222354c95d4d3817 
  src/authentication/http/basic_authenticator_factory.cpp PRE-CREATION 
  src/examples/test_http_authenticator_module.cpp PRE-CREATION 
  src/master/constants.hpp f1624e1ed5091f08f57d4382b344cab8b05ba840 
  src/master/constants.cpp 589f2ee55a24d7e8b9352a4c8f94a3785fd1bef4 
  src/module/manager.cpp 127942e20800d4a6bfff70597e37cb9d76e2270e 
  src/tests/http_authentication_tests.cpp PRE-CREATION 
  src/tests/module.hpp 8e92774ddd51bc8a1368fb1cf6546300696b2d22 
  src/tests/module.cpp 7968519996ca9f9d8895e73d5f173d26a7e794e0 



make check


Alexander Rojas

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message