mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Anand Mazumdar" <>
Subject Re: Review Request 41870: [stout] Added ref-qualifiers to Option::get().
Date Tue, 05 Jan 2016 06:28:17 GMT

This is an automatically generated e-mail. To reply, visit:

(Updated Jan. 5, 2016, 6:28 a.m.)

Review request for mesos, Joris Van Remoortere and Michael Park.


Based on MPark's review comments. Left the decision whether or not to make the copy upon the
user and not the library similar to what Boost `Optional` does.

Repository: mesos


This trivial change adds ref-qualifiers introduced in C++11 to Option::get(). This is in sync
with what boost/folly `optional` already have.

Diffs (updated)

  3rdparty/libprocess/3rdparty/stout/include/stout/option.hpp b58350b312c1969aa86ec679e95af0f97846c141



make check

Verified this enables operations like the following to incur a move instead of a copy:

Option<T> create();
T t = create().get();


Anand Mazumdar

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message