mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Qian Zhang" <zhang...@cn.ibm.com>
Subject Re: Review Request 41705: WIP: Added support for enforcing quota on (persistent) volumes (MESOS-4198).
Date Sat, 26 Dec 2015 05:37:15 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41705/#review111902
-----------------------------------------------------------



src/slave/containerizer/mesos/isolators/posix/disk.cpp (line 171)
<https://reviews.apache.org/r/41705/#comment172197>

    Should we simply use `!Resources::isPersistentVolume()` here?


- Qian Zhang


On Dec. 26, 2015, 10:15 a.m., Artem Harutyunyan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41705/
> -----------------------------------------------------------
> 
> (Updated Dec. 26, 2015, 10:15 a.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Bugs: MESOS-4198
>     https://issues.apache.org/jira/browse/MESOS-4198
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added support for enforcing quota on (persistent) volumes (MESOS-4198).
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/mesos/isolators/posix/disk.cpp d971db09083faad08f3cf18c25a79245321d1d9a

>   src/tests/disk_quota_tests.cpp ce736c32a9e78a8a6d0793a06fe87911b9b0558d 
> 
> Diff: https://reviews.apache.org/r/41705/diff/
> 
> 
> Testing
> -------
> 
> GTEST_FILTER='DiskQuotaTest*' make check -j8
> 
> 
> Thanks,
> 
> Artem Harutyunyan
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message