mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Benjamin Bannier" <>
Subject Re: Review Request 40445: Added linter for license headers in some file types.
Date Thu, 03 Dec 2015 13:06:20 GMT

This is an automatically generated e-mail. To reply, visit:

(Updated Dec. 3, 2015, 1:06 p.m.)

Review request for mesos, Benjamin Hindman, Marco Massenzio, and Michael Park.


Used `str.format` as suggested out-of-band by mcypark.

Also fixed a faulty regex to now actually display `cpplint` issues.

Bugs: MESOS-3581

Repository: mesos

Description (updated)

This adds a style check for license headers in C, C++, and Proto files.

Diffs (updated)

  support/ 66b45692c3c04f68358b63d52e4d87934f241bd7 


Testing (updated)

Ran the a whole clean checkout through the linter with only one expected failure (`3rdparty/libprocess/stout/tests/protobuf_tests.proto`
which lacks a license).

`make check` under OS X 10.10.5 succeeded modulo MESOS-4045.


Benjamin Bannier

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message