mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Avinash sridharan" <avin...@mesosphere.io>
Subject Re: Review Request 40731: Adding the test framework submitted by Mandeep (@mchadha) https://reviews.apache.org/r/39056/
Date Wed, 02 Dec 2015 08:28:34 GMT


> On Nov. 30, 2015, 2:15 p.m., Bernd Mathiske wrote:
> > src/tests/reservation_tests.cpp, line 176
> > <https://reviews.apache.org/r/40731/diff/1/?file=1147237#file1147237line176>
> >
> >     Also see the indentations in various other statements involving argument passing,
etc. Best to sit down with one of us at the same screen and then clean up all these indentations
in one swoop. Respectively see: 
> >     http://mesos.apache.org/documentation/latest/c++-style-guide/

Tried following the style guide as closely as possible. If we still see some missing style
errors will sit with one of the core folks here and fix it.


> On Nov. 30, 2015, 2:15 p.m., Bernd Mathiske wrote:
> > src/tests/reservation_tests.cpp, line 248
> > <https://reviews.apache.org/r/40731/diff/1/?file=1147237#file1147237line248>
> >
> >     s/RESERVE/UNRESERVE/ ?
> >     
> >     What is the intention here? Please explain.

Can you clarify this comment? The idea here seems to be to generate multiple CPU resource
requests. Hence the RESERVE?


- Avinash


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40731/#review108313
-----------------------------------------------------------


On Dec. 2, 2015, 8:27 a.m., Avinash sridharan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40731/
> -----------------------------------------------------------
> 
> (Updated Dec. 2, 2015, 8:27 a.m.)
> 
> 
> Review request for mesos, Bernd Mathiske, Klaus Ma, Mandeep Chadha, and Neil Conway.
> 
> 
> Bugs: MESOS-3552
>     https://issues.apache.org/jira/browse/MESOS-3552
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Adding the test framework submitted by Mandeep (@mchadha) https://reviews.apache.org/r/39056/
> 
> 
> Diffs
> -----
> 
>   src/tests/reservation_tests.cpp e7f14079e766ce0a8bad2da646776347e4a17169 
> 
> Diff: https://reviews.apache.org/r/40731/diff/
> 
> 
> Testing
> -------
> 
> Ran make check after adding Mandeep's test case to the GTEST framework.
> 
> 
> Thanks,
> 
> Avinash sridharan
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message