mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Klaus Ma" <>
Subject Re: Review Request 40631: Move "using mesos::fetcher::FetcherInfo" into internal namespace in "fetcher.hpp"
Date Tue, 01 Dec 2015 12:51:53 GMT

This is an automatically generated e-mail. To reply, visit:

(Updated Dec. 1, 2015, 8:51 p.m.)

Review request for mesos, Benjamin Bannier, Joseph Wu, and Michael Park.


Add comments for `RevocableInfo::Type`

Bugs: MESOS-3963

Repository: mesos


According to the google code style, the using should be used in internal namespace in header
files. Grep the header files, only fetcher.hpp deserved a path.

> You may use a using-declaration anywhere in a .cc file (including in the global namespace),
and in functions, methods, classes, or within internal namespaces in .h files.

>Do not use using-declarations in .h files except in explicitly marked internal-only namespaces,
because anything imported into a namespace in a .h file becomes part of the public API exported
by that file.

// OK in .cc files.
// Must be in a function, method, internal namespace, or
// class in .h files.
using ::foo::bar;

Diffs (updated)

  include/mesos/mesos.proto 27971fe 
  include/mesos/v1/mesos.proto 9acefd5 
  src/common/resources.cpp 98804a4 
  src/tests/resources_tests.cpp dbd39cd 
  src/v1/resources.cpp 8488c31 



make && make check


Klaus Ma

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message