mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Vinod Kone" <vinodk...@gmail.com>
Subject Re: Review Request 39297: Added support for recovering RunState for HTTP based executors
Date Mon, 30 Nov 2015 20:46:59 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39297/#review108385
-----------------------------------------------------------

Ship it!



src/slave/state.cpp (lines 532 - 534)
<https://reviews.apache.org/r/39297/#comment167825>

    Kill this. I don't think we do this for any other states that we recover?



src/slave/state.cpp (lines 546 - 547)
<https://reviews.apache.org/r/39297/#comment167826>

    ditto. kill.


- Vinod Kone


On Nov. 10, 2015, 2:24 p.m., Anand Mazumdar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39297/
> -----------------------------------------------------------
> 
> (Updated Nov. 10, 2015, 2:24 p.m.)
> 
> 
> Review request for mesos, Ben Mahler, Isabel Jimenez, and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This change adds support for recovering the `RunState` for `HTTP` based executors. Upon
agent recovery, it checks if the marker file for HTTP exists and populates `RunState.http`
based on that. This is later used by the Agent for recovering `HTTP` based executors.
> 
> 
> Diffs
> -----
> 
>   src/slave/state.hpp 5a1a9bb2c86639612a8f065b7a66c8179696297a 
>   src/slave/state.cpp d14159f5e8ca9957cbdcce53050b00a00dba2135 
> 
> Diff: https://reviews.apache.org/r/39297/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Anand Mazumdar
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message