mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mesos ReviewBot" <revi...@mesos.apache.org>
Subject Re: Review Request 40010: Put authorize logic for teardown into a common function.
Date Tue, 24 Nov 2015 19:09:03 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40010/#review107804
-----------------------------------------------------------


Patch looks great!

Reviews applied: [40010]

Passed command: export OS=ubuntu:14.04;export CONFIGURATION="--verbose";export COMPILER=gcc;
./support/docker_build.sh

- Mesos ReviewBot


On Nov. 24, 2015, 9:50 a.m., Guangya Liu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40010/
> -----------------------------------------------------------
> 
> (Updated Nov. 24, 2015, 9:50 a.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-3838
>     https://issues.apache.org/jira/browse/MESOS-3838
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> The mesos now have authorizeTask, authorizeFramework etc, it is
> better to put authorize logic for teardown into a common function
> authorizeTeardown.
> 
> 
> Diffs
> -----
> 
>   src/master/http.cpp 6c647808a48879cbc176ffe7586c7e9b41bcf4c8 
>   src/master/master.hpp e5e0ed01a56d869cc535687c8dbb6b99f6295b66 
>   src/master/master.cpp 370980edfc80d1e52134fdaf3ce49177b6528b02 
> 
> Diff: https://reviews.apache.org/r/40010/diff/
> 
> 
> Testing
> -------
> 
> Ubuntu 14.04
> make
> make check
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message