mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Joris Van Remoortere" <joris.van.remoort...@gmail.com>
Subject Re: Review Request 39400: Quota: Implemented quota API.
Date Sun, 22 Nov 2015 19:56:39 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39400/#review107517
-----------------------------------------------------------

Ship it!



src/master/allocator/mesos/hierarchical.cpp (lines 152 - 153)
<https://reviews.apache.org/r/39400/#comment166681>

    Let's add a comment as to why we don't update the quotaRoleSorter here yet (i.e. we do
it during recovery).



src/master/allocator/mesos/hierarchical.cpp (line 1041)
<https://reviews.apache.org/r/39400/#comment166680>

    Let's account for this in the quota role sorter as well (moving it from the next review
into this one):
    ```
    if (roles[role].quota.isSome()) {
      quotaRoleSorter->allocated(role, slaveId, resources.unreserved());
    }
    ```


- Joris Van Remoortere


On Nov. 11, 2015, 10:29 a.m., Alexander Rukletsov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39400/
> -----------------------------------------------------------
> 
> (Updated Nov. 11, 2015, 10:29 a.m.)
> 
> 
> Review request for mesos, Bernd Mathiske, Joerg Schad, Joris Van Remoortere, and Joseph
Wu.
> 
> 
> Bugs: MESOS-3718
>     https://issues.apache.org/jira/browse/MESOS-3718
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   src/master/allocator/mesos/hierarchical.hpp cd0d3e0bd234fcf4db9af2e376ea311937204f75

>   src/master/allocator/mesos/hierarchical.cpp 14fef63714721fcda7cea3c28704766efda6d007

> 
> Diff: https://reviews.apache.org/r/39400/diff/
> 
> 
> Testing
> -------
> 
> make check (Mac OS X 10.10.4)
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message