mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Anand Mazumdar" <mazumdar.an...@gmail.com>
Subject Re: Review Request 40563: Added functionality for handling status updates from HTTP based executors
Date Sat, 21 Nov 2015 01:45:43 GMT


> On Nov. 21, 2015, 12:58 a.m., Vinod Kone wrote:
> > src/slave/http.cpp, lines 318-322
> > <https://reviews.apache.org/r/40563/diff/1/?file=1134992#file1134992line318>
> >
> >     indent by 4 spaces.
> >     
> >     also, it's hard to tell that None() is the argument for statusUpdate() and not
createStatusUpdate()

Fixed the indent. Agreed that None() as a argument is a bit hard to disambiguate but this
is followed elsewhere too. e.g:

https://github.com/apache/mesos/blob/master/src/slave/slave.cpp#L4800


> On Nov. 21, 2015, 12:58 a.m., Vinod Kone wrote:
> > src/slave/slave.cpp, line 2764
> > <https://reviews.apache.org/r/40563/diff/1/?file=1134994#file1134994line2764>
> >
> >     this will be printed by itself on a new line.
> >     
> >     just do;
> >     
> >     LOG(INFO) << "Handling status update " << update
> >               << (pid.isSome() ? " from " + pid.get() : ""):

My bad. Fixed.


- Anand


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40563/#review107452
-----------------------------------------------------------


On Nov. 21, 2015, 12:21 a.m., Anand Mazumdar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40563/
> -----------------------------------------------------------
> 
> (Updated Nov. 21, 2015, 12:21 a.m.)
> 
> 
> Review request for mesos, Ben Mahler, Isabel Jimenez, Marco Massenzio, and Vinod Kone.
> 
> 
> Bugs: MESOS-3476
>     https://issues.apache.org/jira/browse/MESOS-3476
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This change adds the ability for the agent to handle status updates from HTTP based executors.
Previously, the existing `statusUpdate` method used to handle status updates sent from slave
with `pid == UPID()`, sent from other executors/on behalf of other executors with `pid ==
Some()`. This change modifies the argument to be `Option<PID>`. This ensures that `pid
== None()` when set, the ACK is correctly routed to the corresponding HTTP based executor.
> 
> 
> Diffs
> -----
> 
>   src/slave/http.cpp ce48a0584ab18a8d95dd02619f62df18b2276639 
>   src/slave/slave.hpp ec2dfa99e6b553e2bcd82d12db915ae8625075a1 
>   src/slave/slave.cpp d1126f00d947fdb4823b0c495335b743254ac7ee 
> 
> Diff: https://reviews.apache.org/r/40563/diff/
> 
> 
> Testing
> -------
> 
> make check + would add tests once the https://reviews.apache.org/r/39297/ chain is reviewed.
> 
> 
> Thanks,
> 
> Anand Mazumdar
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message