mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Cong Wang" <cw...@twopensource.com>
Subject Re: Review Request 39490: Always create non-IP egress filters
Date Fri, 20 Nov 2015 23:36:22 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39490/
-----------------------------------------------------------

(Updated Nov. 20, 2015, 11:36 p.m.)


Review request for mesos, Ian Downes and Jie Yu.


Changes
-------

Rebase


Repository: mesos


Description
-------

When rolling out the new flag --egress_unique_flow_per_container, I noticed, on some slaves,
only IP egress filters were created as expected, the reset were not. Looking at the code,
it looks like we skipped the creation if this is not the first container we create, this is
wrong for this case, because egress filters were not created for previous containers yet.
We should always create them and ignore error if they exist.


Diffs (updated)
-----

  src/slave/containerizer/mesos/isolators/network/port_mapping.cpp e50616fd609588c547c90bba6d7b3b9b3eb4c6a9


Diff: https://reviews.apache.org/r/39490/diff/


Testing
-------

Manual tests


Thanks,

Cong Wang


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message