mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alexander Rojas" <alexan...@mesosphere.io>
Subject Re: Review Request 40345: [1/4] Quota Authorization: Added "SetQuota" message to ACL protobuf.
Date Fri, 20 Nov 2015 15:40:26 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40345/#review107374
-----------------------------------------------------------



include/mesos/authorizer/authorizer.proto (line 74)
<https://reviews.apache.org/r/40345/#comment166481>

    Can you follow `ShutdownFramework` example and add a one to two lines comment of why is
it here?


- Alexander Rojas


On Nov. 20, 2015, 11:02 a.m., Jan Schlicht wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40345/
> -----------------------------------------------------------
> 
> (Updated Nov. 20, 2015, 11:02 a.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Alexander Rojas, Joris Van Remoortere,
and Till Toenshoff.
> 
> 
> Bugs: MESOS-3862
>     https://issues.apache.org/jira/browse/MESOS-3862
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Quota: Added "RequestQuota" message to ACL protobuf.
> 
> 
> Diffs
> -----
> 
>   include/mesos/authorizer/authorizer.proto 86bbb45f9d91b4098a262e3e50a793f3bb39497e

> 
> Diff: https://reviews.apache.org/r/40345/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Jan Schlicht
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message