mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ben Mahler" <benjamin.mah...@gmail.com>
Subject Re: Review Request 40539: Removed socket from HttpEvent.
Date Fri, 20 Nov 2015 13:51:57 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40539/#review107364
-----------------------------------------------------------

Ship it!


- Ben Mahler


On Nov. 20, 2015, 12:34 p.m., Alexander Rojas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40539/
> -----------------------------------------------------------
> 
> (Updated Nov. 20, 2015, 12:34 p.m.)
> 
> 
> Review request for mesos and Ben Mahler.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> The socket was passed so ProcessBase could access the HttpProxy asociated with
> the socket every time the event was visited. This lead to HTTP pipelining in
> certain circumstances. Once the bug was fixed there was no more use for the
> socket being attached to the HttpEvent.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/include/process/event.hpp 60c615281f3810230bf6c17866f46eaa6855ca29

>   3rdparty/libprocess/src/process.cpp 7abdf21a5784920251c3627f9820c12fdc356c6e 
> 
> Diff: https://reviews.apache.org/r/40539/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Alexander Rojas
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message