mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Joerg Schad" <jo...@mesosphere.io>
Subject Re: Review Request 40396: Quota: Added a test for offer rescinding.
Date Fri, 20 Nov 2015 06:01:29 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40396/#review107310
-----------------------------------------------------------



src/tests/master_quota_tests.cpp (line 454)
<https://reviews.apache.org/r/40396/#comment166368>

    This should be before StartSlave() as otherwise the test might be flaky (in cases where
the slave has been added before the Expect_Call)



src/tests/master_quota_tests.cpp (lines 465 - 466)
<https://reviews.apache.org/r/40396/#comment166369>

    same here



src/tests/master_quota_tests.cpp (line 478)
<https://reviews.apache.org/r/40396/#comment166370>

    same here


- Joerg Schad


On Nov. 17, 2015, 8:18 p.m., Alexander Rukletsov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40396/
> -----------------------------------------------------------
> 
> (Updated Nov. 17, 2015, 8:18 p.m.)
> 
> 
> Review request for mesos, Bernd Mathiske, Joerg Schad, Joris Van Remoortere, Joseph Wu,
and Qian Zhang.
> 
> 
> Bugs: MESOS-3912
>     https://issues.apache.org/jira/browse/MESOS-3912
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   src/tests/master_quota_tests.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/40396/diff/
> 
> 
> Testing
> -------
> 
> make check (Mac OS X 10.10.4)
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message